Close SQLite connections in database tests
This commit is contained in:
1 parent
0f96a01dad
commit
3b91be2872
1 file changed
+11
-2
+11
-2
@@ -1,5 +1,6 @@
|
|||||||
"""Tests for SQLite schema initialization and constraints."""
|
"""Tests for SQLite schema initialization and constraints."""
|
||||||
|
|
||||||
|
from contextlib import contextmanager
|
||||||
import sqlite3
|
import sqlite3
|
||||||
import tempfile
|
import tempfile
|
||||||
import unittest
|
import unittest
|
||||||
@@ -16,10 +17,15 @@ class DatabaseInitializationTests(unittest.TestCase):
|
|||||||
def tearDown(self):
|
def tearDown(self):
|
||||||
self.temp_dir.cleanup()
|
self.temp_dir.cleanup()
|
||||||
|
|
||||||
|
@contextmanager
|
||||||
def connect(self):
|
def connect(self):
|
||||||
connection = sqlite3.connect(self.database_path)
|
connection = sqlite3.connect(self.database_path)
|
||||||
connection.execute("PRAGMA foreign_keys = ON")
|
connection.execute("PRAGMA foreign_keys = ON")
|
||||||
return connection
|
try:
|
||||||
|
with connection:
|
||||||
|
yield connection
|
||||||
|
finally:
|
||||||
|
connection.close()
|
||||||
|
|
||||||
def test_initialization_creates_versioned_schema_and_is_idempotent(self):
|
def test_initialization_creates_versioned_schema_and_is_idempotent(self):
|
||||||
initialize_database(self.database_path)
|
initialize_database(self.database_path)
|
||||||
@@ -79,8 +85,11 @@ class DatabaseInitializationTests(unittest.TestCase):
|
|||||||
|
|
||||||
def test_unknown_future_schema_version_is_rejected(self):
|
def test_unknown_future_schema_version_is_rejected(self):
|
||||||
self.database_path.parent.mkdir(parents=True, exist_ok=True)
|
self.database_path.parent.mkdir(parents=True, exist_ok=True)
|
||||||
with sqlite3.connect(self.database_path) as connection:
|
connection = sqlite3.connect(self.database_path)
|
||||||
|
try:
|
||||||
connection.execute(f"PRAGMA user_version = {SCHEMA_VERSION + 1}")
|
connection.execute(f"PRAGMA user_version = {SCHEMA_VERSION + 1}")
|
||||||
|
finally:
|
||||||
|
connection.close()
|
||||||
|
|
||||||
with self.assertRaises(RuntimeError):
|
with self.assertRaises(RuntimeError):
|
||||||
initialize_database(self.database_path)
|
initialize_database(self.database_path)
|
||||||
|
|||||||
Reference in new issue
Block a user