ai-note: add section 32.7 to the status and to the list of what is left in section 32

This commit is contained in:
ai-bot committed 2026-10-16 16:59:08 +00:00
1 parent 258f356ee2
commit b1e49f71c1
1 file changed
+6 -5
+6 -5
View File
@@ -9,11 +9,11 @@ Short working handover for the next model. Keep it short.
## Status
- **Done and verified:** sections 1–31 and section 18 steps 1–11. **Section 32.1, the icon, is done** — the SVG drawing, the favicon on every page, the top-bar brand mark and the two 192 and 512 px PNGs — together with **section 32.2, the UI pass with the retro theme**, **section 32.3, the alert and page texts**, and **section 32.4, the bug report** (round 32-A and round 32-B). The follow-up round of 32.1 and 32.2 — the favicon, the top-bar brand mark, the footer at the bottom, the single way back, the history button and the three line/table changes in the history view — is done too. Schema version 12. **498 green tests.** The StartOS package is built, sideloaded and running on a StartOS 0.4.0 box; the package version is still `0.1.0:0`.
- **What is left of section 32:** 32.6 the documentation drift, and 32.5 the raise to `1.0.0:0` together with section 18 step 12. 32.6 has to come after 32.1–32.2 and before 32.5. One item inside 32.4 is left to the user: **BR-003** — read the 32.4 section below before acting on it, because the report's own wording for it is out of date. The user's own manual pass is also outstanding: the retro theme on a narrow phone, the footer on a short page, the favicon in the tab, the brand mark in the top bar, installing the PWA with the two PNG icons, the history view after the three changes, and the whole box test again.
- **What is left of section 32:** **32.7 the dashboard menu and the dashboard clean-up** — the six checkboxes in `TODO.md` §32.7 — then 32.6 the documentation drift, and then 32.5 the raise to `1.0.0:0` together with section 18 step 12. 32.6 has to come after the rounds it documents, and 32.5 last. One item inside 32.4 is left to the user: **BR-003** — read the 32.4 section below before acting on it, because the report's own wording for it is out of date. The user's own manual pass is also outstanding: the retro theme on a narrow phone, the footer on a short page, the favicon in the tab, the brand mark in the top bar, installing the PWA with the two PNG icons, the history view after the three changes, and the whole box test again.
- **A round stops when it is done.** Do not start the next item unless the user asks.
- **Verified how:** the automated suite, the user's manual browser testing, and the install and test round on a StartOS 0.4.0 box. The user runs the suite; the agent has no shell.
- **Tests:** `python3 -m unittest discover -s tests`. They run on a Windows copy at `C:\Users\<brukarnamn>\Downloads\helsesjekk`, so they must pass there as well as on Linux.
- **Known gap, still open, folded into 32.6:** `docs/application.md` and `README.md` still describe the API as it was before section 31 — no login/session endpoints, no gating or CSRF rule, the old maintenance command name, the undated export name, and now also the two new summary fields, the moved field reminder, the added `model` field in the check detail, the icon link on the pages and the two PNG icons. The documentation conflict in the bug report (BR-004) covers the same ground.
- **Known gap, still open, folded into 32.6:** `docs/application.md` and `README.md` still describe the API as it was before section 31 — no login/session endpoints, no gating or CSRF rule, the old maintenance command name, the undated export name, and now also the two new summary fields, the moved field reminder, the added `model` field in the check detail, the icon link on the pages and the two PNG icons. The documentation conflict in the bug report (BR-004) covers the same ground. Section 32.7 adds the top-bar menu, the removed dashboard cards, the `Download CSV` link on the history page, and the robots rule to the same list.
## Section 32 — what is left
@@ -21,7 +21,8 @@ Short working handover for the next model. Keep it short.
- **32.2 UI polish — done**, including the follow-up round. See the round 32.2 section below. The only thing left for the user is the manual browser pass on a narrow phone and over the new points.
- **32.3 Alert and page texts — done.** See the round 32.3 section below.
- **32.4 The bug report — done.** See the section below for what each finding turned out to be.
- **32.6 The documentation drift.** `README.md`, `docs/application.md`, `instructions.md`, `UPDATING.md`, `AGENTS.md` and the package's own i18n strings are all behind the code. `TODO.md` §32.6 lists what is wrong in each. It answers the rest of BR-004, and it must be done after 32.1–32.2 and before 32.5, so the documents describe the released state.
- **32.7 The dashboard menu and the dashboard clean-up — open.** Six checkboxes in `TODO.md` §32.7: a `Menu` drop-down in the top bar instead of the Sign out button (`Start health check`, `Settings`, `History`, a separator, `Sign out`); the `Configured setup` / `Your keys` heading and the `#key-count` label gone, with `#key-list` moved up under `#setup-shape`; the `Next check` card gone and the earliest due date moved into `Attention`; no placeholder text in an empty alert list; the dashboard history card gone with `Download CSV` moved to `/history`; and no indexing or crawling (`static/robots.txt`, a `noindex, nofollow` meta on all six pages, and an `X-Robots-Tag` header from `_send_security_headers()`). No schema change, no new endpoint, no new feature, and `static/robots.txt` is the only new file. It has to be done before 32.6, so the documents describe the released state.
- **32.6 The documentation drift.** `README.md`, `docs/application.md`, `instructions.md`, `UPDATING.md`, `AGENTS.md` and the package's own i18n strings are all behind the code. `TODO.md` §32.6 lists what is wrong in each. It answers the rest of BR-004, and it must be done after 32.1–32.2 and 32.7 and before 32.5, so the documents describe the released state.
- **32.5 The version raise.** `0.1.0:0` → `1.0.0:0`, once the items above are done and the user says so. No schema change, no new endpoint, no new feature. `startos/versions/` stays empty, because the app migrates its own schema.
## Round 32.2 — the UI pass and the retro theme
@@ -62,7 +63,7 @@ Seven small changes, no new feature and no schema change. The reasoning is in `T
- **BR-001 — false positive.** The source files are in `main` and tracked by Git. The report was written from the repository's web view, not from a checkout.
- **BR-002 — confirmed and fixed** (round 32-B). See the guard section below. The user has since confirmed by hand that a seed phrase is stopped in the name field and in the address path field.
- **BR-003 — the report's wording is out of date; what is left of it belongs to §32.** The report says the manual end-to-end pass is still open, but it quotes a §31 text that no longer exists, and §16 and §17 record that the manual browser pass and the box tests were run and verified through §31. What is actually outstanding is the **new** manual work §32 adds — the icon (32.1), the UI pass and the retro theme (32.2), the alert texts (32.3), the follow-up round's pages, and the whole box test again after the changes (32.5) — plus the user's confirmation that they have been run. Do not re-verify what §16 and §17 already record as done.
- **BR-003 — the report's wording is out of date; what is left of it belongs to §32.** The report says the manual end-to-end pass is still open, but it quotes a §31 text that no longer exists, and §16 and §17 record that the manual browser pass and the box tests were run and verified through §31. What is actually outstanding is the **new** manual work §32 adds — the icon (32.1), the UI pass and the retro theme (32.2), the alert texts (32.3), the follow-up round's pages, the menu and the dashboard clean-up (32.7), and the whole box test again after the changes (32.5) — plus the user's confirmation that they have been run. Do not re-verify what §16 and §17 already record as done.
- **BR-004 — falls away.** `AI-STATUS.md` and `DATA-MODEL.md` do not exist in this repository, so there is no conflicting pair to reconcile. The real documentation drift is 32.6.
- **BR-005 — verified in code, no behaviour change.** Only `GET /health`, `GET /api/session` and `/login` are open; every other `/api/*` answers `401` and the pages answer `302` to `/login`; every state-changing POST needs a session and the CSRF token (`403`). The `Secure` cookie attribute is deliberately left off, because StartOS terminates TLS and proxies plain HTTP into the container. The report itself says not to change `app.py` behaviour for this one.
- **BR-006 — confirmed and fixed.** The CSV export neutralizes a text cell a spreadsheet would read as a formula.
@@ -195,7 +196,7 @@ The rotate payload is `replaced` + `keep_name` + `name` + `type` + `address_path
Five things that are easy to break:
- New static files must be added to `STATIC_FILES` in `app.py`, or they return `404`. That includes `/settings`, `/settings.js`, `/login`, `/login.js`, `/session.js`, `/sw.js`, `/manifest.webmanifest`, `/icon.svg` and the two raster icons `/icon-192.png` and `/icon-512.png`.
- New static files must be added to `STATIC_FILES` in `app.py`, or they return `404`. That includes `/settings`, `/settings.js`, `/login`, `/login.js`, `/session.js`, `/sw.js`, `/manifest.webmanifest`, `/icon.svg`, the two raster icons `/icon-192.png` and `/icon-512.png`, and `/robots.txt` once section 32.7 lands.
- `/api/setup`, `/api/settings`, `/api/alerts`, `/api/key-status`, `/api/previous-values` and `/api/session` are extra endpoints that are not in the minimum list in section 11.
- `STORAGE_ERRORS` in `app.py` includes `RuntimeError`, because `list_keys()` raises it for a partial setup. Keep it there, or a broken database answers with a traceback instead of a `500`. It also includes `ValueError`, so `validate_admin_credentials()` has to be called in its own `try` and mapped to a `400` before the storage handler — and it is why a refused secret has to be a `ValidationError` rather than a bare `ValueError`.
- The settings, rotation and acknowledgement endpoints keep the same error handling as the existing ones: a bad payload is a `400`, an unknown key or alert is a `404`, a locked or duplicate address path is a `409`, and a broken database is a `500`. `DuplicateAddressPath` and `WalletSoftwareNameInUse` must be caught before the general `ValidationError` — in `_save_key_settings` and `_rotate_key` respectively — or the `409` turns into a `400`. A missing or invalid session is a `401`, and a missing CSRF token is a `403`.