1342 lines
52 KiB
Python
1342 lines
52 KiB
Python
"""Tests for payload validation."""
|
|
|
|
import unittest
|
|
|
|
from validation import (
|
|
DuplicateAddressPath,
|
|
ValidationError,
|
|
WalletSoftwareNameInUse,
|
|
next_check_due,
|
|
validate_acknowledgement,
|
|
validate_health_check,
|
|
validate_key_settings,
|
|
validate_key_setup,
|
|
validate_rotation,
|
|
validate_wallet_software,
|
|
)
|
|
|
|
|
|
# The address path each key slot is configured with (sections 25.1 and 26.2).
|
|
ADDRESS_PATH = "m/48'/0'/0'/2'"
|
|
SECOND_ADDRESS_PATH = "m/48'/1'/0'/2'"
|
|
THIRD_ADDRESS_PATH = "m/48'/2'/0'/2'"
|
|
# A new, unique path a rotation can record (section 26.3).
|
|
NEW_ADDRESS_PATH = "m/48'/7'/0'/2'"
|
|
# The same derivation paths written with the ``h`` hardened marker instead of the
|
|
# apostrophe, which the comparison has to fold together (section 26.2).
|
|
HARDENED_H_PATH = "m/48h/0h/0h/2h"
|
|
SLOT_PATHS = {
|
|
1: ADDRESS_PATH,
|
|
2: SECOND_ADDRESS_PATH,
|
|
3: THIRD_ADDRESS_PATH,
|
|
}
|
|
KEYS = (
|
|
{"id": 1, "key_number": 1, "name": "SeedSigner", "type": "hardware", "address_path": ADDRESS_PATH},
|
|
{"id": 2, "key_number": 2, "name": "Blockstream Jade", "type": "hardware", "address_path": SECOND_ADDRESS_PATH},
|
|
{"id": 3, "key_number": 3, "name": "Nunchuk", "type": "cloud", "address_path": THIRD_ADDRESS_PATH},
|
|
)
|
|
# A setup with the cloud key in the first slot, renamed hardware keys, and a
|
|
# different address path per key, to show that the comparison is per key and that
|
|
# the type decides the checks and never the key number.
|
|
RENAMED_KEYS = (
|
|
{"id": 1, "key_number": 1, "name": "Coinbase", "type": "cloud", "address_path": ADDRESS_PATH},
|
|
{"id": 2, "key_number": 2, "name": "ColdCard", "type": "hardware", "address_path": SECOND_ADDRESS_PATH},
|
|
{"id": 3, "key_number": 3, "name": "Jade", "type": "hardware", "address_path": THIRD_ADDRESS_PATH},
|
|
)
|
|
# The wallet software list the settings hold (section 25.4).
|
|
SOFTWARE_NAMES = ("Sparrow Wallet",)
|
|
|
|
|
|
def key_for(key_number, keys=KEYS):
|
|
"""Return the key profile with the given number."""
|
|
return next(entry for entry in keys if entry["key_number"] == key_number)
|
|
|
|
|
|
def path_for(key_number):
|
|
"""Return the address path of a key slot, so a setup never repeats one."""
|
|
return SLOT_PATHS.get(key_number, ADDRESS_PATH)
|
|
|
|
|
|
def entry(key_number, name, key_type, address_path=None, model=None):
|
|
"""Return one key of a setup payload.
|
|
|
|
The address path defaults to the path of that key slot, so a valid setup
|
|
keeps one path per key unless a test asks for another one (section 26.2).
|
|
The model is optional documentation, so it defaults to an empty value
|
|
(section 31 point 5).
|
|
"""
|
|
return {
|
|
"key_number": key_number,
|
|
"name": name,
|
|
"type": key_type,
|
|
"address_path": path_for(key_number) if address_path is None else address_path,
|
|
"model": model,
|
|
}
|
|
|
|
|
|
def validate(payload, keys=KEYS, software_names=SOFTWARE_NAMES):
|
|
"""Return a validated payload, with the settings list the app passes."""
|
|
return validate_health_check(payload, keys, software_names)
|
|
|
|
|
|
def sample_payload(key_number=1, wallet_software=None, keys=KEYS, address_path=None):
|
|
"""Return a valid single-key payload for the given key number.
|
|
|
|
The recorded address path matches the stored one unless a test asks for
|
|
another one (section 25.1).
|
|
"""
|
|
key = key_for(key_number, keys)
|
|
if wallet_software is None:
|
|
wallet_software = key["name"] if key["type"] == "cloud" else "Sparrow Wallet"
|
|
labels = list(dict.fromkeys((key["name"], wallet_software)))
|
|
entry_payload = {
|
|
"key_id": key["id"],
|
|
"available": 1,
|
|
"address_path": address_path if address_path is not None else key["address_path"],
|
|
"comments": "",
|
|
}
|
|
if key["type"] == "hardware":
|
|
entry_payload.update({
|
|
"hardware_works": 1,
|
|
"firmware_version": "1.0.0",
|
|
"seed_backup_verified": "OK",
|
|
})
|
|
return {
|
|
"checked_at": "2026-10-01",
|
|
"wallet_software": wallet_software,
|
|
"software_version": "1.8.0",
|
|
"software_compatibility_status": "OK",
|
|
"software_comments": "",
|
|
"contact_info_verified": "Confirmed current",
|
|
"comments": "Annual review",
|
|
"key_check": entry_payload,
|
|
"ai_security_checks": [
|
|
{"provider": label, "status": "SECURE", "comments": ""} for label in labels
|
|
],
|
|
}
|
|
|
|
|
|
def unavailable_payload(key_number=1, keys=KEYS):
|
|
"""Return the payload the form sends for a key that was not available."""
|
|
key = key_for(key_number, keys)
|
|
return {
|
|
"checked_at": "2026-10-01",
|
|
"wallet_software": None,
|
|
"software_compatibility_status": "NOT_ASSESSED",
|
|
"contact_info_verified": "Needs external update",
|
|
"comments": "Annual review",
|
|
"key_check": {
|
|
"key_id": key["id"],
|
|
"available": 0,
|
|
"comments": "Key is with the third holder",
|
|
},
|
|
"ai_security_checks": [],
|
|
}
|
|
|
|
|
|
def mismatch_payload(key_number=1, address_path="m/48'/9'/0'/2'", keys=KEYS):
|
|
"""Return the minimal payload the form sends when the path does not match.
|
|
|
|
Everything else about the key is left out, because the key could not be
|
|
checked (section 25.1).
|
|
"""
|
|
key = key_for(key_number, keys)
|
|
return {
|
|
"checked_at": "2026-10-01",
|
|
"contact_info_verified": "Confirmed current",
|
|
"comments": "Annual review",
|
|
"key_check": {
|
|
"key_id": key["id"],
|
|
"available": 1,
|
|
"address_path": address_path,
|
|
"comments": "Path read from the device",
|
|
},
|
|
}
|
|
|
|
|
|
class KeySetupTests(unittest.TestCase):
|
|
def test_a_valid_setup_is_normalized_and_sorted(self):
|
|
result = validate_key_setup({"keys": [
|
|
entry(3, " Nunchuk ", "cloud"),
|
|
entry(1, "ColdCard", "hardware"),
|
|
entry(2, "Jade", "hardware"),
|
|
]})
|
|
|
|
self.assertEqual(
|
|
result,
|
|
[
|
|
entry(1, "ColdCard", "hardware"),
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
],
|
|
)
|
|
|
|
def test_all_three_keys_may_be_cloud_keys(self):
|
|
result = validate_key_setup({"keys": [
|
|
entry(1, "Provider one", "cloud"),
|
|
entry(2, "Provider two", "cloud"),
|
|
entry(3, "Provider three", "cloud"),
|
|
]})
|
|
|
|
self.assertEqual([item["type"] for item in result], ["cloud"] * 3)
|
|
|
|
def test_duplicate_names_are_rejected_without_regard_to_case(self):
|
|
for names in (("Jade", "Jade"), ("Jade", "jade"), ("Jade", " JADE ")):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": [
|
|
entry(1, names[0], "hardware"),
|
|
entry(2, names[1], "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
def test_an_empty_or_non_text_name_is_rejected(self):
|
|
for name in ("", " ", None, 12):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": [
|
|
entry(1, name, "hardware"),
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
def test_an_over_long_name_is_rejected(self):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": [
|
|
entry(1, "x" * 61, "hardware"),
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
def test_an_unknown_type_is_rejected(self):
|
|
for key_type in ("", "hardware ", "cloudy", None):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": [
|
|
entry(1, "ColdCard", key_type),
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
def test_a_repeated_or_unknown_key_number_is_rejected(self):
|
|
for numbers in ((1, 1, 3), (1, 2, 4), (0, 2, 3), (1, 2, None), (1, 2, True)):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": [
|
|
entry(numbers[0], "ColdCard", "hardware"),
|
|
entry(numbers[1], "Jade", "hardware"),
|
|
entry(numbers[2], "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
def test_the_wrong_number_of_keys_is_rejected(self):
|
|
single = entry(1, "ColdCard", "hardware")
|
|
for entries in ([], [single], [single, single], [single] * 4):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": entries})
|
|
|
|
def test_a_missing_key_list_is_rejected(self):
|
|
for payload in ({}, {"keys": None}, {"keys": "ColdCard"}, []):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup(payload)
|
|
|
|
def test_the_address_path_is_required_for_every_key(self):
|
|
# ``entry()`` fills in the path of the key slot, so the value is set
|
|
# explicitly here: an empty, non-text or missing path is refused
|
|
# (section 25.1).
|
|
for value in ("", " ", None, 12):
|
|
first = entry(1, "ColdCard", "hardware")
|
|
first["address_path"] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": [
|
|
first,
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
missing = entry(1, "ColdCard", "hardware")
|
|
del missing["address_path"]
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": [
|
|
missing,
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
def test_an_over_long_address_path_is_rejected(self):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": [
|
|
entry(1, "ColdCard", "hardware", "m/" + "x" * 200),
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
def test_two_keys_may_not_share_an_address_path(self):
|
|
# The address path is part of the identity of a key, so no two keys may
|
|
# share one, and the message names the key that already has it
|
|
# (section 26.2).
|
|
with self.assertRaises(ValidationError) as context:
|
|
validate_key_setup({"keys": [
|
|
entry(1, "ColdCard", "hardware", ADDRESS_PATH),
|
|
entry(2, "Jade", "hardware", ADDRESS_PATH),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
self.assertIn("key 1: ColdCard", str(context.exception))
|
|
|
|
def test_the_path_comparison_ignores_case_and_spacing(self):
|
|
for value in (f" {ADDRESS_PATH} ", ADDRESS_PATH.upper()):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": [
|
|
entry(1, "ColdCard", "hardware", ADDRESS_PATH),
|
|
entry(2, "Jade", "hardware", value),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
def test_the_path_comparison_folds_the_hardened_marker(self):
|
|
# ``h`` and the apostrophe name the same derivation path, so the two
|
|
# spellings may not be configured as two keys (section 26.2).
|
|
for value in (
|
|
HARDENED_H_PATH,
|
|
HARDENED_H_PATH.upper(),
|
|
f" {HARDENED_H_PATH} ",
|
|
):
|
|
with self.assertRaises(ValidationError) as context:
|
|
validate_key_setup({"keys": [
|
|
entry(1, "ColdCard", "hardware", ADDRESS_PATH),
|
|
entry(2, "Jade", "hardware", value),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
self.assertIn("key 1: ColdCard", str(context.exception))
|
|
|
|
def test_each_key_keeps_its_own_path(self):
|
|
result = validate_key_setup({"keys": [
|
|
entry(1, "ColdCard", "hardware"),
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
self.assertEqual(
|
|
[item["address_path"] for item in result],
|
|
[ADDRESS_PATH, SECOND_ADDRESS_PATH, THIRD_ADDRESS_PATH],
|
|
)
|
|
|
|
|
|
class ModelTests(unittest.TestCase):
|
|
def test_a_setup_records_the_optional_model(self):
|
|
# The model is documentation only, so it is trimmed and kept per key
|
|
# (section 31 point 5).
|
|
result = validate_key_setup({"keys": [
|
|
entry(1, "ColdCard", "hardware", model=" ColdCard Q "),
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud", model="Casa"),
|
|
]})
|
|
|
|
self.assertEqual([item["model"] for item in result], ["ColdCard Q", None, "Casa"])
|
|
|
|
def test_an_empty_model_is_not_recorded(self):
|
|
for value in ("", " ", None):
|
|
result = validate_key_setup({"keys": [
|
|
entry(1, "ColdCard", "hardware", model=value),
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
self.assertIsNone(result[0]["model"])
|
|
|
|
def test_an_over_long_or_non_text_model_is_rejected(self):
|
|
for value in ("x" * 61, 12):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_setup({"keys": [
|
|
entry(1, "ColdCard", "hardware", model=value),
|
|
entry(2, "Jade", "hardware"),
|
|
entry(3, "Nunchuk", "cloud"),
|
|
]})
|
|
|
|
def test_the_settings_normalize_the_model(self):
|
|
result = validate_key_settings(
|
|
{"key_id": 1, "name": "ColdCard", "address_path": ADDRESS_PATH, "model": " ColdCard Q "},
|
|
KEYS,
|
|
)
|
|
self.assertEqual(result["model"], "ColdCard Q")
|
|
|
|
# The model is optional, so a missing or empty one means "not recorded".
|
|
for value in ("", " ", None):
|
|
empty = validate_key_settings(
|
|
{"key_id": 1, "name": "ColdCard", "address_path": ADDRESS_PATH, "model": value},
|
|
KEYS,
|
|
)
|
|
self.assertIsNone(empty["model"])
|
|
|
|
def test_the_rotation_normalizes_the_model(self):
|
|
result = validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
"model": " Ledger Nano S ",
|
|
},
|
|
KEYS,
|
|
1,
|
|
)
|
|
self.assertEqual(result["model"], "Ledger Nano S")
|
|
|
|
# A rotation that says nothing about the model leaves it out, so the
|
|
# caller can keep the stored value (section 31 point 5).
|
|
missing = validate_rotation(
|
|
{"replaced": True, "keep_name": True, "address_path": NEW_ADDRESS_PATH},
|
|
KEYS,
|
|
1,
|
|
)
|
|
self.assertIsNone(missing["model"])
|
|
|
|
|
|
class ValidationTests(unittest.TestCase):
|
|
def test_valid_payload_is_normalized(self):
|
|
result = validate(sample_payload())
|
|
|
|
self.assertEqual(result["checked_at"], "2026-10-01")
|
|
self.assertEqual(result["comments"], "Annual review")
|
|
self.assertEqual(result["key_check"]["key_id"], 1)
|
|
self.assertEqual(result["key_check"]["seed_backup_verified"], "OK")
|
|
self.assertEqual(len(result["ai_security_checks"]), 2)
|
|
|
|
def test_the_configured_name_is_the_product_label(self):
|
|
result = validate(sample_payload(key_number=2, keys=RENAMED_KEYS), RENAMED_KEYS)
|
|
|
|
self.assertEqual(result["wallet_software"], "Sparrow Wallet")
|
|
self.assertEqual(
|
|
[item["provider"] for item in result["ai_security_checks"]],
|
|
["ColdCard", "Sparrow Wallet"],
|
|
)
|
|
|
|
def test_a_cloud_key_records_its_own_name_once(self):
|
|
result = validate(sample_payload(key_number=1, keys=RENAMED_KEYS), RENAMED_KEYS)
|
|
|
|
self.assertEqual(result["wallet_software"], "Coinbase")
|
|
self.assertEqual([item["provider"] for item in result["ai_security_checks"]], ["Coinbase"])
|
|
self.assertIsNone(result["key_check"]["hardware_works"])
|
|
self.assertIsNone(result["key_check"]["seed_backup_verified"])
|
|
|
|
def test_a_hardware_key_may_use_a_cloud_key_name_as_its_software(self):
|
|
payload = sample_payload(key_number=2, keys=RENAMED_KEYS)
|
|
payload["wallet_software"] = "Coinbase"
|
|
payload["ai_security_checks"] = [
|
|
{"provider": label, "status": "SECURE", "comments": ""}
|
|
for label in ("ColdCard", "Coinbase")
|
|
]
|
|
|
|
result = validate(payload, RENAMED_KEYS)
|
|
|
|
self.assertEqual(result["wallet_software"], "Coinbase")
|
|
self.assertEqual(
|
|
[item["provider"] for item in result["ai_security_checks"]],
|
|
["ColdCard", "Coinbase"],
|
|
)
|
|
|
|
def test_a_hardware_key_name_is_not_a_wallet_software_choice(self):
|
|
# "Jade" is a hardware key in this setup, so it is never software.
|
|
payload = sample_payload(key_number=2, keys=RENAMED_KEYS)
|
|
payload["wallet_software"] = "Jade"
|
|
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload, RENAMED_KEYS)
|
|
|
|
def test_the_wallet_software_choices_are_the_settings_list_and_the_cloud_keys(self):
|
|
# A name from the settings list is a choice for a hardware key, and a
|
|
# name that is in neither is not (section 25.4).
|
|
payload = sample_payload()
|
|
payload["wallet_software"] = "BlueWallet"
|
|
payload["ai_security_checks"] = [
|
|
{"provider": label, "status": "SECURE", "comments": ""}
|
|
for label in ("SeedSigner", "BlueWallet")
|
|
]
|
|
|
|
result = validate(payload, KEYS, ("BlueWallet",))
|
|
self.assertEqual(result["wallet_software"], "BlueWallet")
|
|
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_a_cloud_key_rejects_another_wallet_software(self):
|
|
for value in ("Sparrow Wallet", "ColdCard"):
|
|
payload = sample_payload(key_number=1, keys=RENAMED_KEYS)
|
|
payload["wallet_software"] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload, RENAMED_KEYS)
|
|
|
|
def test_next_check_due_is_derived_on_the_server(self):
|
|
payload = sample_payload()
|
|
payload["next_check_due"] = "1999-01-01"
|
|
|
|
result = validate(payload)
|
|
|
|
self.assertEqual(result["next_check_due"], "2027-10-01")
|
|
|
|
def test_leap_day_is_clamped_to_the_last_day_of_february(self):
|
|
self.assertEqual(next_check_due("2028-02-29"), "2029-02-28")
|
|
self.assertEqual(next_check_due("2026-02-28"), "2027-02-28")
|
|
|
|
def test_blank_text_is_stored_as_null(self):
|
|
payload = sample_payload()
|
|
payload["software_version"] = " "
|
|
|
|
result = validate(payload)
|
|
|
|
self.assertIsNone(result["software_version"])
|
|
|
|
def test_invalid_dates_are_rejected(self):
|
|
for value in ("01-10-2026", "", None, "2026-13-01"):
|
|
payload = sample_payload()
|
|
payload["checked_at"] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_unsupported_status_is_rejected(self):
|
|
payload = sample_payload()
|
|
payload["software_compatibility_status"] = "MAYBE"
|
|
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_compatibility_status_requires_an_explicit_choice(self):
|
|
# "not assessed" is no longer submittable for a new registration
|
|
# (section 23.1).
|
|
for value in ("", None, "NOT_ASSESSED", "IKKJE_VURDERT"):
|
|
payload = sample_payload()
|
|
payload["software_compatibility_status"] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_compatibility_status_accepts_ok_and_problem(self):
|
|
for value in ("OK", "PROBLEM"):
|
|
payload = sample_payload()
|
|
payload["software_compatibility_status"] = value
|
|
self.assertEqual(
|
|
validate(payload)["software_compatibility_status"],
|
|
value,
|
|
)
|
|
|
|
def test_cloud_key_compatibility_is_derived_from_availability(self):
|
|
payload = sample_payload(key_number=3)
|
|
payload["software_compatibility_status"] = "OK"
|
|
self.assertEqual(
|
|
validate(payload)["software_compatibility_status"],
|
|
"OK",
|
|
)
|
|
|
|
for value in ("PROBLEM", "NOT_ASSESSED"):
|
|
payload = sample_payload(key_number=3)
|
|
payload["software_compatibility_status"] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_unavailable_key_keeps_the_derived_compatibility(self):
|
|
payload = unavailable_payload()
|
|
payload["software_compatibility_status"] = "NOT_ASSESSED"
|
|
self.assertEqual(
|
|
validate(payload)["software_compatibility_status"],
|
|
"NOT_ASSESSED",
|
|
)
|
|
|
|
payload["software_compatibility_status"] = "OK"
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_not_assessed_is_only_the_derived_compatibility(self):
|
|
# No other field offers or accepts NOT_ASSESSED (section 24.1).
|
|
payload = sample_payload()
|
|
payload["key_check"]["seed_backup_verified"] = "NOT_ASSESSED"
|
|
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_hardware_works_is_required_for_an_available_hardware_key(self):
|
|
# Hardware works requires an active Yes or No (section 24.1).
|
|
for value in ("", None, "NOT_ASSESSED"):
|
|
payload = sample_payload()
|
|
payload["key_check"]["hardware_works"] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
payload = sample_payload()
|
|
del payload["key_check"]["hardware_works"]
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_hardware_works_accepts_yes_and_no(self):
|
|
for value in (1, 0):
|
|
payload = sample_payload()
|
|
payload["key_check"]["hardware_works"] = value
|
|
self.assertEqual(
|
|
validate(payload)["key_check"]["hardware_works"],
|
|
value,
|
|
)
|
|
|
|
def test_contact_status_uses_the_two_stored_values(self):
|
|
for value in ("Confirmed current", "Needs external update"):
|
|
payload = sample_payload()
|
|
payload["contact_info_verified"] = value
|
|
self.assertEqual(
|
|
validate(payload)["contact_info_verified"], value
|
|
)
|
|
|
|
def test_contact_status_is_required_and_never_a_flag(self):
|
|
# The confirmation is required, also when the key was not available,
|
|
# because the question is still asked (section 24.1).
|
|
for payload in (sample_payload(), unavailable_payload()):
|
|
for value in ("", None):
|
|
payload["contact_info_verified"] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
del payload["contact_info_verified"]
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
# The old 0/1 flag is no longer a valid value (section 23.1).
|
|
for value in (1, 0, True, "yes"):
|
|
payload = sample_payload()
|
|
payload["contact_info_verified"] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_security_status_must_use_the_four_english_values(self):
|
|
for value in ("TRYGG", "UNKNOWN", ""):
|
|
payload = sample_payload()
|
|
payload["ai_security_checks"][0]["status"] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_security_labels_are_specific_to_the_selected_key(self):
|
|
payload = sample_payload(key_number=1)
|
|
payload["ai_security_checks"] = [
|
|
{"provider": "SeedSigner", "status": "SECURE", "comments": ""},
|
|
{"provider": "Sparrow Wallet", "status": "SECURE", "comments": ""},
|
|
{"provider": "Blockstream Jade", "status": "SECURE", "comments": ""},
|
|
]
|
|
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_unknown_key_id_is_rejected(self):
|
|
payload = sample_payload()
|
|
payload["key_check"]["key_id"] = 99
|
|
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_missing_key_check_is_rejected(self):
|
|
payload = sample_payload()
|
|
del payload["key_check"]
|
|
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_the_server_sets_the_address_path_verification(self):
|
|
result = validate(sample_payload())
|
|
|
|
self.assertEqual(result["key_check"]["address_path"], ADDRESS_PATH)
|
|
self.assertEqual(result["key_check"]["address_path_verified"], "OK")
|
|
|
|
def test_the_address_path_is_compared_after_stripping(self):
|
|
payload = sample_payload()
|
|
payload["key_check"]["address_path"] = f" {ADDRESS_PATH} "
|
|
|
|
result = validate(payload)
|
|
|
|
self.assertEqual(result["key_check"]["address_path"], ADDRESS_PATH)
|
|
self.assertEqual(result["key_check"]["address_path_verified"], "OK")
|
|
|
|
def test_a_path_written_with_the_h_marker_is_the_keys_own_path(self):
|
|
# The same derivation path written with the ``h`` marker is the key's own
|
|
# path, so the check is verified and not reported as a mismatch
|
|
# (sections 25.1 and 26.2). The recorded spelling is kept as it is.
|
|
result = validate(sample_payload(address_path=HARDENED_H_PATH))
|
|
|
|
self.assertEqual(result["key_check"]["address_path"], HARDENED_H_PATH)
|
|
self.assertEqual(result["key_check"]["address_path_verified"], "OK")
|
|
|
|
def test_a_different_address_path_makes_the_key_uncheckable(self):
|
|
result = validate(mismatch_payload(1, "m/48'/9'/0'/2'"))
|
|
key_check = result["key_check"]
|
|
|
|
# The recorded path and the key note are kept, while the rest of the
|
|
# check is empty and the compatibility stays not assessed
|
|
# (section 25.1).
|
|
self.assertEqual(key_check["address_path"], "m/48'/9'/0'/2'")
|
|
self.assertEqual(key_check["address_path_verified"], "PROBLEM")
|
|
self.assertEqual(key_check["comments"], "Path read from the device")
|
|
self.assertEqual(key_check["available"], 1)
|
|
self.assertIsNone(key_check["hardware_works"])
|
|
self.assertIsNone(key_check["firmware_version"])
|
|
self.assertIsNone(key_check["seed_backup_verified"])
|
|
self.assertIsNone(result["wallet_software"])
|
|
self.assertEqual(result["software_compatibility_status"], "NOT_ASSESSED")
|
|
self.assertEqual(result["ai_security_checks"], [])
|
|
self.assertEqual(result["contact_info_verified"], "Confirmed current")
|
|
self.assertEqual(result["comments"], "Annual review")
|
|
|
|
def test_a_mismatched_submission_rejects_recorded_results(self):
|
|
recorded = (
|
|
("wallet_software", "Sparrow Wallet"),
|
|
("ai_security_checks", [
|
|
{"provider": "SeedSigner", "status": "SECURE", "comments": ""}
|
|
]),
|
|
("software_compatibility_status", "OK"),
|
|
)
|
|
for field, value in recorded:
|
|
payload = mismatch_payload()
|
|
payload[field] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_the_path_of_another_key_does_not_match(self):
|
|
# The comparison uses the selected key's own path (section 25.1), so the
|
|
# path of another key is a mismatch for this one, while the key's own
|
|
# path is accepted.
|
|
result = validate(mismatch_payload(2, ADDRESS_PATH, RENAMED_KEYS), RENAMED_KEYS)
|
|
|
|
self.assertEqual(result["key_check"]["address_path"], ADDRESS_PATH)
|
|
self.assertEqual(result["key_check"]["address_path_verified"], "PROBLEM")
|
|
|
|
own_path = validate(sample_payload(key_number=2, keys=RENAMED_KEYS), RENAMED_KEYS)
|
|
self.assertEqual(
|
|
own_path["key_check"]["address_path"], SECOND_ADDRESS_PATH
|
|
)
|
|
self.assertEqual(own_path["key_check"]["address_path_verified"], "OK")
|
|
|
|
def test_a_submitted_verification_result_is_ignored(self):
|
|
# The client never sends the result, and the server overrules it anyway
|
|
# (section 25.1).
|
|
payload = mismatch_payload()
|
|
payload["key_check"]["address_path_verified"] = "OK"
|
|
self.assertEqual(validate(payload)["key_check"]["address_path_verified"], "PROBLEM")
|
|
|
|
payload = sample_payload()
|
|
payload["key_check"]["address_path_verified"] = "PROBLEM"
|
|
self.assertEqual(validate(payload)["key_check"]["address_path_verified"], "OK")
|
|
|
|
def test_an_unavailable_key_never_reports_a_mismatch(self):
|
|
# A key that was not available records no path at all, so nothing is
|
|
# compared (sections 22 and 25.1).
|
|
result = validate(unavailable_payload())
|
|
|
|
self.assertIsNone(result["key_check"]["address_path"])
|
|
self.assertIsNone(result["key_check"]["address_path_verified"])
|
|
|
|
def test_a_missing_address_path_does_not_match_a_stored_one(self):
|
|
payload = mismatch_payload()
|
|
del payload["key_check"]["address_path"]
|
|
|
|
result = validate(payload)
|
|
|
|
self.assertEqual(result["key_check"]["address_path_verified"], "PROBLEM")
|
|
|
|
def test_verification_status_is_required_when_the_key_is_available(self):
|
|
payload = sample_payload()
|
|
payload["key_check"]["seed_backup_verified"] = ""
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_verification_status_rejects_not_assessed(self):
|
|
payload = sample_payload()
|
|
payload["key_check"]["seed_backup_verified"] = "NOT_ASSESSED"
|
|
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_availability_is_required(self):
|
|
for value in ("", None):
|
|
payload = sample_payload()
|
|
payload["key_check"]["available"] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_a_minimal_unavailable_payload_is_accepted(self):
|
|
# The check date, the key check, and the contact confirmation are the
|
|
# minimum, because the confirmation is required for every submission
|
|
# (section 24.1).
|
|
payload = {
|
|
"checked_at": "2026-10-01",
|
|
"contact_info_verified": "Needs external update",
|
|
"key_check": {"key_id": 1, "available": 0},
|
|
}
|
|
|
|
result = validate(payload)
|
|
|
|
self.assertEqual(result["next_check_due"], "2027-10-01")
|
|
self.assertEqual(result["key_check"]["available"], 0)
|
|
self.assertIsNone(result["wallet_software"])
|
|
self.assertEqual(result["ai_security_checks"], [])
|
|
self.assertEqual(result["software_compatibility_status"], "NOT_ASSESSED")
|
|
self.assertEqual(result["contact_info_verified"], "Needs external update")
|
|
self.assertIsNone(result["comments"])
|
|
|
|
def test_an_unavailable_key_rejects_recorded_results(self):
|
|
recorded = (
|
|
("wallet_software", "Sparrow Wallet"),
|
|
("ai_security_checks", [{"provider": "SeedSigner", "status": "SECURE", "comments": ""}]),
|
|
)
|
|
for field, value in recorded:
|
|
payload = unavailable_payload()
|
|
payload[field] = value
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
def test_an_unavailable_hardware_key_records_nothing_else(self):
|
|
payload = unavailable_payload()
|
|
payload["key_check"].update({
|
|
"hardware_works": 1,
|
|
"firmware_version": "1.0.0",
|
|
"seed_backup_verified": "PROBLEM",
|
|
"address_path": ADDRESS_PATH,
|
|
})
|
|
|
|
result = validate(payload)
|
|
|
|
self.assertEqual(result["key_check"]["available"], 0)
|
|
self.assertIsNone(result["key_check"]["hardware_works"])
|
|
self.assertIsNone(result["key_check"]["firmware_version"])
|
|
self.assertIsNone(result["key_check"]["seed_backup_verified"])
|
|
self.assertIsNone(result["key_check"]["address_path_verified"])
|
|
self.assertIsNone(result["key_check"]["address_path"])
|
|
self.assertEqual(result["key_check"]["comments"], "Key is with the third holder")
|
|
|
|
def test_an_unavailable_cloud_key_records_nothing_else(self):
|
|
payload = unavailable_payload(key_number=3)
|
|
payload["key_check"].update({
|
|
"address_path": ADDRESS_PATH,
|
|
"comments": "Key is with the third holder",
|
|
})
|
|
|
|
result = validate(payload)
|
|
|
|
self.assertEqual(result["key_check"]["available"], 0)
|
|
self.assertIsNone(result["key_check"]["address_path_verified"])
|
|
self.assertIsNone(result["key_check"]["address_path"])
|
|
self.assertEqual(result["software_compatibility_status"], "NOT_ASSESSED")
|
|
self.assertEqual(result["key_check"]["comments"], "Key is with the third holder")
|
|
|
|
def test_over_long_text_is_rejected(self):
|
|
payload = sample_payload()
|
|
payload["comments"] = "x" * 4001
|
|
|
|
with self.assertRaises(ValidationError):
|
|
validate(payload)
|
|
|
|
|
|
class KeySettingsTests(unittest.TestCase):
|
|
def test_a_new_name_and_path_are_normalized(self):
|
|
result = validate_key_settings(
|
|
{"key_id": 1, "name": " ColdCard ", "address_path": f" {ADDRESS_PATH} "},
|
|
KEYS,
|
|
)
|
|
|
|
self.assertEqual(
|
|
result,
|
|
{"key_id": 1, "name": "ColdCard", "address_path": ADDRESS_PATH, "model": None},
|
|
)
|
|
|
|
def test_the_type_is_never_part_of_the_settings(self):
|
|
# The type is part of the identity of a key, so only a rotation may
|
|
# change it, and the settings never read it (sections 25.2 and 28).
|
|
result = validate_key_settings(
|
|
{"key_id": 1, "name": "ColdCard", "address_path": ADDRESS_PATH, "type": "cloud"},
|
|
KEYS,
|
|
)
|
|
|
|
self.assertNotIn("type", result)
|
|
|
|
def test_an_unknown_key_is_rejected(self):
|
|
for key_id in (99, None, "1", True):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_settings(
|
|
{"key_id": key_id, "name": "ColdCard", "address_path": ADDRESS_PATH},
|
|
KEYS,
|
|
)
|
|
|
|
def test_the_name_is_required_and_must_be_unique(self):
|
|
for name in ("", " ", None, 12, "x" * 61):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_settings(
|
|
{"key_id": 1, "name": name, "address_path": ADDRESS_PATH}, KEYS
|
|
)
|
|
|
|
# A name that repeats another key's name is refused without regard to
|
|
# case, while the key's own name is of course allowed (section 25.2).
|
|
for name in ("Nunchuk", "nunchuk", " NUNCHUK "):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_settings(
|
|
{"key_id": 1, "name": name, "address_path": ADDRESS_PATH}, KEYS
|
|
)
|
|
|
|
result = validate_key_settings(
|
|
{"key_id": 3, "name": "Nunchuk", "address_path": THIRD_ADDRESS_PATH}, KEYS
|
|
)
|
|
self.assertEqual(result["name"], "Nunchuk")
|
|
|
|
def test_the_address_path_is_required(self):
|
|
for value in ("", " ", None, 12, "m/" + "x" * 200):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_settings(
|
|
{"key_id": 1, "name": "ColdCard", "address_path": value}, KEYS
|
|
)
|
|
|
|
def test_a_path_that_another_key_already_has_is_rejected(self):
|
|
# The settings answer a duplicate path with 409, so the error is kept
|
|
# apart from the other validation errors (section 26.2).
|
|
with self.assertRaises(DuplicateAddressPath) as context:
|
|
validate_key_settings(
|
|
{"key_id": 2, "name": "Jade", "address_path": ADDRESS_PATH}, KEYS
|
|
)
|
|
|
|
self.assertIn("key 1: SeedSigner", str(context.exception))
|
|
|
|
def test_the_comparison_ignores_case_and_spacing(self):
|
|
for value in (f" {ADDRESS_PATH} ", ADDRESS_PATH.upper()):
|
|
with self.assertRaises(DuplicateAddressPath):
|
|
validate_key_settings(
|
|
{"key_id": 2, "name": "Jade", "address_path": value}, KEYS
|
|
)
|
|
|
|
def test_the_duplicate_check_folds_the_hardened_marker(self):
|
|
# The path of key 1 written with the ``h`` marker is still the path of
|
|
# key 1, so the settings refuse it for key 2 (section 26.2).
|
|
with self.assertRaises(DuplicateAddressPath) as context:
|
|
validate_key_settings(
|
|
{"key_id": 2, "name": "Jade", "address_path": HARDENED_H_PATH}, KEYS
|
|
)
|
|
|
|
self.assertIn("key 1: SeedSigner", str(context.exception))
|
|
|
|
def test_a_key_may_keep_its_own_path(self):
|
|
result = validate_key_settings(
|
|
{"key_id": 2, "name": "Jade", "address_path": SECOND_ADDRESS_PATH}, KEYS
|
|
)
|
|
|
|
self.assertEqual(result["address_path"], SECOND_ADDRESS_PATH)
|
|
|
|
def test_a_missing_or_wrong_payload_is_rejected(self):
|
|
for payload in ({}, [], {"key_id": 1}, {"name": "ColdCard"}):
|
|
with self.assertRaises(ValidationError):
|
|
validate_key_settings(payload, KEYS)
|
|
|
|
|
|
class WalletSoftwareTests(unittest.TestCase):
|
|
def test_a_valid_list_is_normalized(self):
|
|
result = validate_wallet_software(
|
|
{"wallet_software": [" Sparrow Wallet ", "BlueWallet"]}, KEYS
|
|
)
|
|
|
|
self.assertEqual(result, ["Sparrow Wallet", "BlueWallet"])
|
|
|
|
def test_sparrow_may_be_replaced_by_another_name(self):
|
|
# The list may not be emptied, but the entry a new database starts with
|
|
# may be replaced once another name has been added (section 25.4).
|
|
result = validate_wallet_software({"wallet_software": ["BlueWallet"]}, KEYS)
|
|
|
|
self.assertEqual(result, ["BlueWallet"])
|
|
|
|
def test_an_empty_list_is_rejected(self):
|
|
with self.assertRaises(ValidationError):
|
|
validate_wallet_software({"wallet_software": []}, KEYS)
|
|
|
|
def test_a_missing_or_wrong_list_is_rejected(self):
|
|
for payload in ({}, [], {"wallet_software": None}, {"wallet_software": "Sparrow Wallet"}):
|
|
with self.assertRaises(ValidationError):
|
|
validate_wallet_software(payload, KEYS)
|
|
|
|
def test_an_empty_or_over_long_name_is_rejected(self):
|
|
for value in ("", " ", None, 12, "x" * 61):
|
|
with self.assertRaises(ValidationError):
|
|
validate_wallet_software({"wallet_software": [value]}, KEYS)
|
|
|
|
def test_a_repeated_name_is_rejected_without_regard_to_case(self):
|
|
for names in (["BlueWallet", "BlueWallet"], ["BlueWallet", "bluewallet"]):
|
|
with self.assertRaises(ValidationError):
|
|
validate_wallet_software({"wallet_software": names}, KEYS)
|
|
|
|
def test_a_cloud_key_name_is_rejected(self):
|
|
# A cloud key already provides its own name as a choice (section 25.4).
|
|
for name in ("Nunchuk", "nunchuk", " NUNCHUK "):
|
|
with self.assertRaises(ValidationError):
|
|
validate_wallet_software({"wallet_software": [name]}, KEYS)
|
|
|
|
# A hardware key name is not a cloud key name, so it is allowed.
|
|
result = validate_wallet_software({"wallet_software": ["SeedSigner"]}, KEYS)
|
|
self.assertEqual(result, ["SeedSigner"])
|
|
|
|
|
|
class RotationTests(unittest.TestCase):
|
|
def test_keeping_the_name_needs_no_name(self):
|
|
result = validate_rotation(
|
|
{"replaced": True, "keep_name": True, "address_path": NEW_ADDRESS_PATH}, KEYS, 1
|
|
)
|
|
|
|
self.assertEqual(result, {
|
|
"key_id": 1,
|
|
"keep_name": True,
|
|
"name": None,
|
|
"type": "hardware",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
"model": None,
|
|
})
|
|
|
|
def test_changing_the_name_requires_a_unique_non_empty_name(self):
|
|
for name in ("", " ", None, 12, "x" * 61, "Nunchuk", "nunchuk"):
|
|
with self.assertRaises(ValidationError):
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": False,
|
|
"name": name,
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
1,
|
|
)
|
|
|
|
result = validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": False,
|
|
"name": " ColdCard ",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
1,
|
|
)
|
|
self.assertEqual(result, {
|
|
"key_id": 1,
|
|
"keep_name": False,
|
|
"name": "ColdCard",
|
|
"type": "hardware",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
"model": None,
|
|
})
|
|
|
|
def test_the_replacement_must_be_confirmed(self):
|
|
for value in (None, False, 0, 1, "yes", "true"):
|
|
with self.assertRaises(ValidationError):
|
|
validate_rotation(
|
|
{
|
|
"replaced": value,
|
|
"keep_name": True,
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
1,
|
|
)
|
|
|
|
def test_keep_name_must_be_a_boolean(self):
|
|
for value in (None, "yes", 1, 0, ""):
|
|
with self.assertRaises(ValidationError):
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": value,
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
1,
|
|
)
|
|
|
|
def test_a_new_address_path_is_required(self):
|
|
# The rotation replaces the key, so the path has to change, and an empty
|
|
# value is refused (section 26.3).
|
|
for value in (None, "", " ", 12, "m/" + "x" * 200):
|
|
with self.assertRaises(ValidationError):
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"address_path": value,
|
|
},
|
|
KEYS,
|
|
1,
|
|
)
|
|
|
|
with self.assertRaises(ValidationError):
|
|
validate_rotation({"replaced": True, "keep_name": True}, KEYS, 1)
|
|
|
|
def test_the_stored_path_is_refused_as_the_new_one(self):
|
|
# The key is a new one, so its old path may not be recorded again
|
|
# (section 26.3).
|
|
for value in (ADDRESS_PATH, f" {ADDRESS_PATH} ", ADDRESS_PATH.upper()):
|
|
with self.assertRaises(ValidationError):
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"address_path": value,
|
|
},
|
|
KEYS,
|
|
1,
|
|
)
|
|
|
|
def test_the_stored_path_is_refused_in_either_marker(self):
|
|
# The stored path written with the ``h`` marker is the same derivation
|
|
# path, so the rotation refuses it as the new one too (sections 26.2 and
|
|
# 26.3).
|
|
for value in (HARDENED_H_PATH, HARDENED_H_PATH.upper()):
|
|
with self.assertRaises(ValidationError):
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"address_path": value,
|
|
},
|
|
KEYS,
|
|
1,
|
|
)
|
|
|
|
def test_a_path_that_another_key_already_has_is_rejected(self):
|
|
with self.assertRaises(DuplicateAddressPath):
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"address_path": ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
2,
|
|
)
|
|
|
|
def test_an_unknown_key_is_rejected(self):
|
|
for key_id in (99, None, "1", True):
|
|
with self.assertRaises(ValidationError):
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
key_id,
|
|
)
|
|
|
|
def test_the_type_is_kept_when_it_is_left_out(self):
|
|
# The type is part of the identity of a key, and the setup locks it, so
|
|
# a rotation that says nothing about it keeps the type the key has
|
|
# (section 28).
|
|
hardware = validate_rotation(
|
|
{"replaced": True, "keep_name": True, "address_path": NEW_ADDRESS_PATH}, KEYS, 1
|
|
)
|
|
cloud = validate_rotation(
|
|
{"replaced": True, "keep_name": True, "address_path": NEW_ADDRESS_PATH}, KEYS, 3
|
|
)
|
|
|
|
self.assertEqual(hardware["type"], "hardware")
|
|
self.assertEqual(cloud["type"], "cloud")
|
|
|
|
def test_the_replacement_may_carry_the_other_type(self):
|
|
# The rotation replaces the key, so the replacement may be the other type
|
|
# (section 28).
|
|
to_cloud = validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"type": "cloud",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
1,
|
|
)
|
|
to_hardware = validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"type": "hardware",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
3,
|
|
)
|
|
|
|
self.assertEqual(to_cloud["type"], "cloud")
|
|
self.assertEqual(to_hardware["type"], "hardware")
|
|
|
|
def test_an_unknown_type_is_rejected(self):
|
|
for value in ("", " ", "usb", "Cloud", 12, True):
|
|
with self.assertRaises(ValidationError):
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"type": value,
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
1,
|
|
)
|
|
|
|
def test_a_key_that_becomes_a_cloud_key_needs_a_free_name(self):
|
|
# A cloud key offers its own name as a wallet software choice, and the
|
|
# settings list holds the other choices, so the same name cannot be both,
|
|
# and the rotation is refused (sections 25.4 and 28).
|
|
for names in (
|
|
("SeedSigner",),
|
|
("seedsigner",),
|
|
(" SeedSigner ",),
|
|
("Sparrow Wallet", "SeedSigner"),
|
|
):
|
|
with self.assertRaises(WalletSoftwareNameInUse):
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"type": "cloud",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
1,
|
|
names,
|
|
)
|
|
|
|
# Without the list there is nothing to collide with, and a name the list
|
|
# does not hold is accepted.
|
|
self.assertEqual(
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"type": "cloud",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
1,
|
|
)["type"],
|
|
"cloud",
|
|
)
|
|
self.assertEqual(
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"type": "cloud",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
1,
|
|
("BlueWallet",),
|
|
)["type"],
|
|
"cloud",
|
|
)
|
|
|
|
def test_the_new_name_is_the_one_that_has_to_be_free(self):
|
|
# The check reads the name the replacement ends up with, so a new name
|
|
# that the list already holds is refused as well (section 28).
|
|
with self.assertRaises(WalletSoftwareNameInUse) as context:
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": False,
|
|
"name": "BlueWallet",
|
|
"type": "cloud",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
1,
|
|
("BlueWallet",),
|
|
)
|
|
|
|
self.assertIn("BlueWallet", str(context.exception))
|
|
|
|
def test_a_cloud_key_may_not_be_renamed_to_a_taken_software_name(self):
|
|
# A key that stays a cloud key offers its own name, so the same rule
|
|
# holds there, and the list entry has to be removed first
|
|
# (sections 25.4 and 28).
|
|
with self.assertRaises(WalletSoftwareNameInUse):
|
|
validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": False,
|
|
"name": "BlueWallet",
|
|
"type": "cloud",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
3,
|
|
("BlueWallet",),
|
|
)
|
|
|
|
def test_a_cloud_key_that_becomes_a_hardware_key_keeps_its_name(self):
|
|
# A hardware key name is not a wallet software choice, so the list may
|
|
# hold it and nothing collides (sections 25.4 and 28).
|
|
result = validate_rotation(
|
|
{
|
|
"replaced": True,
|
|
"keep_name": True,
|
|
"type": "hardware",
|
|
"address_path": NEW_ADDRESS_PATH,
|
|
},
|
|
KEYS,
|
|
3,
|
|
("Nunchuk",),
|
|
)
|
|
|
|
self.assertEqual(result["type"], "hardware")
|
|
|
|
|
|
class AcknowledgementTests(unittest.TestCase):
|
|
def test_a_valid_acknowledgement_is_normalized(self):
|
|
result = validate_acknowledgement({
|
|
"code": "address_path_mismatch",
|
|
"source": " Key 1: SeedSigner ",
|
|
"action": "ignore",
|
|
})
|
|
|
|
self.assertEqual(result, {
|
|
"code": "address_path_mismatch",
|
|
"source": "Key 1: SeedSigner",
|
|
"action": "ignore",
|
|
})
|
|
|
|
def test_an_unknown_or_removed_code_is_rejected(self):
|
|
# The removed rules can no longer be triggered or acknowledged
|
|
# (section 25.3).
|
|
for code in ("cloud_provider_problem", "address_verification_failed", "UNKNOWN", "", None):
|
|
with self.assertRaises(ValidationError):
|
|
validate_acknowledgement({
|
|
"code": code,
|
|
"source": "Key 1: SeedSigner",
|
|
"action": "ignore",
|
|
})
|
|
|
|
def test_only_a_closing_action_is_accepted(self):
|
|
# A rotation goes through the rotation endpoint, because it requires a new
|
|
# address path, and the removed generic acknowledgement is gone
|
|
# (sections 26.3 and 26.4).
|
|
for action in ("rotate", "acknowledge", "ROTATE", "UNKNOWN", "", None, 12):
|
|
with self.assertRaises(ValidationError):
|
|
validate_acknowledgement({
|
|
"code": "key_unavailable",
|
|
"source": "Key 1: SeedSigner",
|
|
"action": action,
|
|
})
|
|
|
|
for action in ("replace_hardware", "remove_software", "ignore", "contact_updated"):
|
|
result = validate_acknowledgement({
|
|
"code": "key_unavailable",
|
|
"source": "Key 1: SeedSigner",
|
|
"action": action,
|
|
})
|
|
self.assertEqual(result["action"], action)
|
|
|
|
def test_the_source_is_required(self):
|
|
for value in ("", " ", None, 12, "x" * 201):
|
|
with self.assertRaises(ValidationError):
|
|
validate_acknowledgement({
|
|
"code": "key_unavailable",
|
|
"source": value,
|
|
"action": "ignore",
|
|
})
|
|
|
|
payload = {"code": "key_unavailable", "action": "ignore"}
|
|
with self.assertRaises(ValidationError):
|
|
validate_acknowledgement(payload)
|
|
|
|
def test_a_missing_or_wrong_payload_is_rejected(self):
|
|
for payload in ({}, [], {"code": "key_unavailable"}):
|
|
with self.assertRaises(ValidationError):
|
|
validate_acknowledgement(payload)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|