20 KiB
AI Agent Note — Helsesjekk
Short working handover for the next model. Keep it short.
TODO.md(Norwegian) is the requirement specification: sections 1–18 are the spec, sections 19–22 a short appendix with the four decisions taken along the way, section 23 the configurable key setup, section 24 the required choices and the removal of BIP327/SLIP39, and section 25 the address path identity, the key rotation, the alert acknowledgement, and the settings page.- The binding rules live in
TODO.mdandREADME.md. This note does not repeat them — it carries the handover, the rules that are easy to get wrong, and the traps that already cost time. HANDOVER.mdwas deleted as outdated. Do not recreate it.
Status
- Done and verified: sections 19–22, section 18 steps 1–8, sections 23 and 24.
- Done, waiting for verification: the whole of section 25. It is implemented and the test files are updated, but the user has not run the suite yet, so the section 25 boxes in
TODO.mdare still unticked and the test count in section 18 still says 178. - Verified how: the automated suite only. The browser flows and the migration of a real older database have not been run by hand yet; they are the manual tests in section 16 of
TODO.md. - Tests: the user runs them:
python3 -m unittest discover -s tests. They run on a Windows copy atC:\Users\Driftsleiar\Downloads\helsesjekk, so they must pass there as well as on Linux. - Next work after section 25 is verified: section 18 steps 9–12 — the StartOS package, the persistent volume, backup/restore, and
.s9pk. Covered by sections 13, 14, 16 and 17 ofTODO.md. Do not start it before the user says so. - Future work, deliberately not built: more than three keys, and another threshold than 2-of-3 (section 23).
Section 25 — implemented, waiting for verification
Read section 25 of TODO.md for the full list. What was built, and the parts that are easy to get wrong:
- The address path is the identity of a key, together with its type.
keys.address_pathwas added (a non-empty value in the setup,TEXT NOT NULL DEFAULT ''in the table),/setupasks for it, and the form records onlyAddress path, pre-filled fromkey.address_path. The name is a label that the settings may change. - The server derives
address_path_verified. It compares the recorded path withkeys.address_pathafter stripping both: equal givesOK, different givesPROBLEM. A submittedaddress_path_verifiedis ignored (the user chose alternative A): the server always writes its own value, so a stale client that claimsOKis overruled and an alert can never be lost. The comparison only happens whenavailableis1, so an unavailable key never reports a mismatch and never raises the mismatch alert. - A mismatch is treated like a key that could not be checked.
address_path, the key note, the contact confirmation and the overall comment are stored; the hardware, the software and the security results stay empty,wallet_softwareisNULL, andsoftware_compatibility_statusisNOT_ASSESSED. Sending software or security results with a mismatched path is a400, exactly as section 22 does for an unavailable key.software_versionfollows section 22 as well: it is read as text and stored. - The form warns before it submits.
#address-path-warningappears when the recorded path differs, with the checkbox#address-path-confirmed. That checkbox isrequiredonly while the warning is visible, so a required control is never hidden. When the path does not match, the browser builds the minimal payload itself and the review summary marks the choice. - The wallet software list replaced the built-in Sparrow choice.
validation.pyno longer hasSPARROW_SOFTWARE; the choices aresoftware_namesfrom the settings plus the configured cloud key names.POST /api/settings/wallet-softwarestores the whole list, which must hold at least one name, may not repeat a name, and may not contain a name that a cloud key already provides. A new database is seeded withSparrow Wallet, so the user must add an alternative before the list can be emptied. /settingsis new and is inSTATIC_FILES. It holds01 / Keys,02 / Wallet softwareand03 / Key rotation. The keys section saves one key at a time (POST /api/settings/keys), the address path input isdisabledwhen the key has checks, andhas_checksfromGET /api/settingstells the page which keys those are.- Rotation lives only in the settings.
POST /api/keys/<id>/rotatetakesreplaced,address_path_unchanged,keep_nameandname; both confirmations must betrueandkeep_namemust be a real boolean. The page can rotate several keys in one action, but it sends one request per key, because section 11 fixes the endpoint per key. The rotation updates the key row, closes the alerts its own checks raised, and changes no earlier check. The page states that rotating a key creates a new wallet, so the funds must be moved from the old multisig setup before the old keys are discarded. - Acknowledging an alert stores a fifth field.
alert_acknowledgementsholdscode,source,reason,acknowledged_atandcheck_id(the user chose alternative B). An alert is hidden whilealert.check_id <= acknowledgement.check_id, so a newer check, which always has a higher id, raises it again whatever date it carries. The date-comparison variant was rejected because a new check saved on the same day as the acknowledgement would stay hidden. - Every alert carries
actionsandkey_id.actionsisrotate,acknowledge, or both, and the dashboard renders one control per action. The endpoint does not enforce which action may close an alert (the user chose that): the UI shows only the offered controls, and the app never performs an action itself. - The two dead alert rules are gone.
cloud_provider_problemandaddress_verification_failedwere removed, and the merged cloud wording ofkey_unavailablewent with them, so one message covers every key. - Schema version 10.
keys.address_path, thewallet_softwaretable and thealert_acknowledgementstable were added, andcloud_health_statusandcloud_provider_operationalwere dropped fromkey_checks. There is no data migration for an older test database: the user deletes thedatafolder and configures the setup again._key_checks_need_rebuildalso rebuilds when it still sees the two cloud columns. - The form label and the cloud version field.
Software version (if used)becameSoftware version, and the version field moved out of the grid that is hidden for a cloud key, so every key has it. The version is still reused from the last saved value for the same key and software. - A latent bug was fixed on the way. The grid with the wallet software and the compatibility result is hidden for a cloud key, and those two controls used to stay
required, which blocks a submission with "An invalid form control is not focusable".syncUncheckableStatenow clears the flag for a cloud key as well.
Section 24 — implemented and verified
Read section 24 of TODO.md for the summary. 24.2 and 24.4 were delivered together on purpose, so the schema went to version 9 in one step.
- 24.1:
Hardware worksis a requiredYes/NowithSelect statusas a non-answer first option, for an available hardware key only; the required flag is cleared when the key is unavailable. The contact confirmation is a requiredConfirmed current/Needs external update, also for an unavailable key.NOT_ASSESSEDsurvives only as the derivedsoftware_compatibility_statusof a key that could not be checked. - 24.2 and 24.4: the whole BIP327/SLIP39 function is gone (form, validation, alerts, history, CSV columns), and schema version 9 drops the
tool_checkstable with its rows. - 24.3: the form is renumbered to 01 Schedule, 02 Key, 03 Compatibility, 04 External research, 05 Contact confirmation, 06 Notes.
04 / Standardsis gone. - 24.5: the BIP327/SLIP39 tests were removed, tests for the required choices and for the version 8 → 9 migration were added, and
README.mdwas updated.
Section 23.2–23.5 — implemented and verified
- The setup is stored once.
POST /api/setupwrites the three key rows; a second call is a409, because the type and the address path are locked (section 23.2 and 25.1).GET /api/setupanswers{"configured": …, "keys": […]}. - A new database shows the setup step.
/setupis a page inSTATIC_FILES, andstatic/app.js,static/health-check.jsandstatic/settings.jssend the browser there when the setup is missing. - An existing database is migrated, not replaced.
list_keys()reads the stored rows. A database with 1 or 2 key rows raisesRuntimeErrorand is never answered with the setup step. - The name is the product label.
ai_security_checks.providerholds the configured key name and the selected wallet software, sovalidation.pybuilds the list from the key, andstatic/health-check.jsdoes the same inexpectedLabels(). - The type decides, never the number.
_key_check()and_compatibility_status()switch onkey["type"], and the script does too. - The wallet software choices are the settings list plus every configured cloud key name. A hardware key name is never a choice. A cloud key records its own name, because the provider is the software for that key.
- The setup is validated.
validate_key_setup()rejects a wrong number of keys, a repeated or out-of-range key number, an empty or over-long name, a name that repeats another one without regard to case, an unknown type, and an empty or over-long address path. Name uniqueness is enforced there and not by aUNIQUEconstraint, so a legacy database with odd rows is refused by the API instead of being impossible to open. The same path for two keys is allowed.
Known leftovers
/api/previous-valuesstill returns asecuritymap that nothing consumes any more, and itsaddress_pathper key is no longer used by the form, which pre-fills the path fromkeys.address_path. Both are deliberate: removing them would shrink the endpoint, but nothing breaks while they stay.
Rules that are easy to get wrong — do not re-open
- One submission records one key. There is no "round" grouping, and each key's next check is its own date plus one calendar year, computed on the server and not editable in the form.
- A key that could not be checked records nothing else. That covers
available=0and a recorded address path that does not match.wallet_softwareandai_security_checksmust be empty; a non-empty value is a400, not something dropped silently. Nothing is stored for them, andsoftware_compatibility_statusbecomesNOT_ASSESSED(onlyNOT_ASSESSED,""ornullmay accompany it). Availabilityis required and offers only Yes/No. There is no "not assessed" value for it, and the server rejects a payload without it.- A cloud key collects only
Availability. Cloud health, "provider operational" and software compatibility are all derived from it, and its own name is the wallet software. The two derived cloud columns and their alerts are gone (section 25.6). - A hardware key needs an explicit compatibility status.
OKorPROBLEM; a missing value andNOT_ASSESSEDare both a400(section 23.1). Hardware worksneeds an explicitYesorNofor an available hardware key (section 24.1). A missing value,""andNOT_ASSESSEDare all a400; only a key that could not be checked leaves it empty.- The contact confirmation is required for every submission, including one for a key that could not be checked, and it has no "not assessed" value (section 24.1).
NOT_ASSESSEDis not offered or accepted anywhere else (section 24.1). No field but the derivedsoftware_compatibility_statusaccepts it.Address path verifiedis never a form field again. The server derives it from the comparison (section 25.1). The stored column stays, so the history, the export and the alerts keep working.- The address path is locked after the first saved check.
POST /api/settings/keysaccepts the stored path again but answers409for a different one. /api/alertscovers every saved check, not only the newest, merges identical alerts bycodeplussource, and leaves out the acknowledged ones. A security alert'ssourceis the provider, which is the key's configured name or the software name.- The export is plain CSV only. XLSX is not built and the app does not promise Excel compatibility.
- The prohibition lists in sections 1 and 13 of
TODO.mdstay unticked. They are standing prohibitions, to be re-confirmed before release. - Whether a date is overdue is decided in the browser, so
/api/key-statusstays independent of the current date.
Data model (schema version 10)
keys:key_number(1–3),name,type(hardware/cloud),address_path,created_at. There is nodevicecolumn. The name is editable in the settings; the type and the address path are the identity of the key.health_checks:checked_at,next_check_due,wallet_software,software_version,software_compatibility_status,software_comments,contact_info_verified,comments, plus the legacysparrow_version/nunchuk_version.wallet_softwareandcontact_info_verifiedare free text.key_checks: one row per submission —available,hardware_works,firmware_version,seed_backup_verified,address_path_verified,address_path,comments. The two cloud columns are gone.ai_security_checks:provider(free text),status,comments, withUNIQUE (health_check_id, provider).wallet_software:name,created_at. Stored whole, seeded withSparrow Walletwhen the list is empty, never emptied through the API.alert_acknowledgements:code,source,check_id,reason,acknowledged_at.tool_checksno longer exists. Version 9 dropped it with its rows (sections 24.2 and 24.4).- Startup migration rebuilds
keyswhen it still hasdevice,key_checkswhen it uses the old layout or still holds the two cloud columns, andhealth_checksandkey_checkswhen theirCHECKconstraints still allow the old values. It then dropstool_checksif it is there. - The table definitions are
{table}templates, so a rebuild can create the same table under a temporary name.health_checksis a parent table, so the whole migration runs withPRAGMA foreign_keys = OFF, checksPRAGMA foreign_key_checkbefore committing, and rolls back on any failure. tests/test_database.pycarriesLEGACY_SCHEMA,SCHEMA_VERSION_5,SCHEMA_VERSION_8andSCHEMA_VERSION_9as literal older schemas. Copy that pattern for a new migration test: write the old schema, runinitialize_database(), then assert on the migrated rows.
API
Pages: /, /setup, /settings, /health-check, /history. Endpoints: GET /health, GET /api/setup, POST /api/setup, GET /api/keys, GET /api/key-status, GET /api/previous-values, GET /api/settings, POST /api/settings/keys, POST /api/settings/wallet-software, POST /api/keys/<id>/rotate, GET /api/health-checks, GET /api/health-checks/<id>, GET /api/alerts, POST /api/alerts/acknowledge, GET /api/export, POST /api/health-checks. Field details are in README.md.
Five things that are easy to break:
- New static files must be added to
STATIC_FILESinapp.py, or they return404. That includes/settingsand/settings.js. /api/setup,/api/settings,/api/alerts,/api/key-statusand/api/previous-valuesare extra endpoints that are not in the minimum list in section 11. They are noted in section 11 but not in the specification itself.STORAGE_ERRORSinapp.pyincludesRuntimeError, becauselist_keys()raises it for a partial setup. Keep it there, or a broken database answers with a traceback instead of a500.- The settings, rotation and acknowledgement endpoints keep the same error handling as the existing ones: a bad payload is a
400, an unknown key or alert is a404, a locked address path is a409, and a broken database is a500. newest_alert_check_id()inapp.pyderives the check id for both the acknowledgement and the rotation, so the same comparison rule is used in both places.
Traps that already cost time — do not repeat
with sqlite3.connect(...)does not close the connection. It only commits or rolls back the transaction. On Windows the database file stays locked andTemporaryDirectory.cleanup()fails withWinError 32. Always close explicitly withtry/finally; seewrite_schema()intests/test_database.py.- A
requiredcontrol inside adisplay:nonecontainer still blocks submission. The browser refuses to submit and logs "An invalid form control is not focusable". Hiding a section is not enough: the required flags must be cleared, or the section must render something other than required fields. That is whyrenderSecurityChecks()shows an empty note instead of cards when a key could not be checked, whysyncUncheckableState()clears the flags on the wallet software and the compatibility select — also for a cloud key, whose grid is hidden — and whysyncRequiredFields()clears the flag onhardware_worksandseed_backup_verified. - The mismatch confirmation follows its warning.
#address-path-confirmedisrequiredonly while#address-path-warningis visible, so the browser itself stops the submission and a required control is never hidden. - The page heading uses
class="eyebrow"too. A regex overhealth-check.htmlfindsAnnual security checkbefore the numbered sections, andsettings.htmlstarts withSettings. A test on the section order must expect that first. - Do not assert on the quoting style of the JavaScript.
static/health-check.jsuses single quotes for constant selectors and template literals where a${...}substitution is needed, andstatic/settings.jsuses double quotes. Assert on the selector text, e.g.[name="address_path"], and on quote-free substrings such as/api/settingsand/settings?rotate=. clean_record()intests/test_alerts.pyhas a fixed provider list and now carrieskey_id. A test that needs another provider must replace the entry itself. The cloud fields are gone from it, so a test that wants to prove the removed rules cannot be triggered adds them to the record itself.sample_payload()/unavailable_payload()are duplicated intests/test_validation.py,tests/test_database.pyandtests/test_app.py. They build the labels from the key's name and the selected software, they always sendcontact_info_verified, and for a hardware keyhardware_works. They must send the key's ownaddress_path, because the server compares it with the stored one;tests/test_app.pyandtests/test_database.pyalso have amismatch_payload()for the minimal mismatching submission.validate_health_check()takes a third argument. The wallet software list from the settings must be passed in, or a hardware key that selects a settings name is refused.tests/test_validation.pywraps it in a smallvalidate()helper for that reason.tests/test_app.pyhas six test classes.ServerTestCasestarts the server,AppHandlerTestsstores the default setup insetUp,RenamedSetupTestsstores the renamed one,SettingsApiTests,RotationApiTestsandAcknowledgementApiTestsstore the default one, andKeySetupApiTestsleaves the database empty. A new test must go in the class whose setup it needs.- Section 19 records one key per submission, so a
Check idin the export can cover up to three keys only for rows saved before section 19.
Product clarification
The key's configured name is its product label, and a cloud key's name is also a wallet-software choice. A hardware key name is never a wallet-software choice, and a cloud key records its own name as its software. A key is identified by its type and its address path, while the name is only a label that the user may change, or replace during a rotation. A rotation creates a new wallet, so the funds have to be moved from the old multisig setup to the new one before the old keys are discarded.